Aws s3#2418
Closed
jonodrew wants to merge 4 commits into
Closed
Conversation
Signed-off-by: jonathan.kerr <3410350+jonodrew@users.noreply.github.com>
This should add an S3 bucket and a role that can do things with it. Signed-off-by: jonathan.kerr <3410350+jonodrew@users.noreply.github.com>
This creates a user and the appropriate role for the user. I've used the sts AssumeRole approach here, to separate the admin role from the user Signed-off-by: jonathan.kerr <3410350+jonodrew@users.noreply.github.com>
Signed-off-by: jonathan.kerr <3410350+jonodrew@users.noreply.github.com>
till
requested changes
Dec 9, 2025
|
|
||
| # 1. S3 Bucket (private by default) | ||
| resource "aws_s3_bucket" "auth_bucket" { | ||
| bucket = "codebar-planner-auth-bucket" |
Collaborator
There was a problem hiding this comment.
It would be nice to create buckets myself, but otherwise I'd like 2 - one prod, one staging.
| "s3:GetObject", # Read/download files | ||
| "s3:PutObject", # Upload files | ||
| "s3:DeleteObject", # Optional: allow deleting files | ||
| "s3:ListAllMyBuckets" # enable user to list all buckets |
Collaborator
There was a problem hiding this comment.
This should be un-scoped - per bucket, you need something like this (this is the json format):
{
"Version":"2012-10-17",
"Statement":[
{
"Effect":"Allow",
"Action": "s3:ListAllMyBuckets",
"Resource":"*"
},
{
"Effect":"Allow",
"Action":["s3:ListBucket","s3:GetBucketLocation"],
"Resource":"arn:aws:s3:::bucket-name-etc"
},
{
"Effect":"Allow",
"Action":[
"s3:PutObject",
"s3:GetObject",
"s3:DeleteObject"
],
"Resource":"arn:aws:s3:::bucket-name-etc/*"
}
]
}
Collaborator
|
Do we still need this PR? |
Collaborator
No, good for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outline terraform for creating an S3 bucket and IAM role for @till to try out his auth stuff